Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable tracing for now #80

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: disable tracing for now #80

merged 1 commit into from
Nov 22, 2024

Conversation

travis
Copy link
Member

@travis travis commented Nov 22, 2024

we currently overwhelm sentry

@travis
fix: disable tracing for now
3e22bc0 
we currently overwhelm sentry
@seed-deploy seed-deploy bot temporarily deployed to pr80 November 22, 2024 00:29 Inactive
@seed-deploy Seed Deploy
Copy link

seed-deploy bot commented Nov 22, 2024

View stack outputs

fforbeck
fforbeck approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@fforbeck fforbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is ok to disable it for a moment. I was wondering if we should set a lower sample rate instead. Something like 0.1 to get at least some of the errors.

@travis travis merged commit 98b4fed into main Nov 22, 2024
3 checks passed
@travis travis deleted the fix/traces branch November 22, 2024 15:40
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fforbeck fforbeck fforbeck approved these changes

@Peeja Peeja Awaiting requested review from Peeja

@alanshaw alanshaw Awaiting requested review from alanshaw

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

@volmedo volmedo Awaiting requested review from volmedo

@BravoNatalie BravoNatalie Awaiting requested review from BravoNatalie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travis @fforbeck