Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing recommended packages #110

Open
nobodyinperson opened this issue Nov 14, 2019 · 5 comments
Open

Installing recommended packages #110

nobodyinperson opened this issue Nov 14, 2019 · 5 comments
Labels
enhancement Is supposed to enhance something

Comments

@nobodyinperson
Copy link

Currently, it is not possible to install packages listed in the Recommends SPEC-file section via Storeman. An option to (try to) install as many of the recommended packages would be very useful from a packaging point of view: Packages adding features to an application but known to be not installable on some systems are usually put into the Recommends section. With an option to also install recommended packages, the user wouldn't need to be instructed to install package X and Y manually for this or that feature.

I'd welcome such a feature for Hasher and OpenSenseFish for example, but I suppose a lot of other developers would benefit from that.

That being said (and me knowing nothing about PackageKit), this might as well not be possible with PackageKit. pkcon at least doesn't seem to offer such functionality. zypper does, however.

@Thaodan
Copy link
Contributor

Thaodan commented May 14, 2020

Could you test who this works on suse with newer libzypp and packagekit?

@Olf0
Copy link
Member

Olf0 commented Mar 17, 2022

Because Recommends: has always been a no-op
on SailfishOS most packages do not use it.
Edit: See next message for details.

But RPM recommends that the Recommends: weak dependency is ignored by simple command line tools (as rpm), while GUI tools and advanced command line tools might offer the choice to install the recommended packages (usually by an interactive dialogue).
Recommends: needs rpm ≥ 4.13 (to be recognised as a keyword) and SFOS 3.2.1 already deploys v4.14.1.

@Olf0 Olf0 added the enhancement Is supposed to enhance something label Mar 17, 2022
@Olf0
Copy link
Member

Olf0 commented Feb 28, 2024

Because Recommends: has always been a no-op
on SailfishOS most packages do not use it.

This is not the case for libzypp, when configured so (see solver.onlyRequires configuration option in /etc/zypp/zypp.conf, which defaults to install recommended packages, in contrast to rpm, which can query Recommends weak dependencies since v4.13, but not utilise them) and consequently frontends which use it: zypper and pkcon.
zypper additionally allows to override the behaviour defined for libzypp by configuration or the options --recommends and --no-recommends.

Now I wonder, why Storeman, which uses packagekitd via D-Bus does not seem to install recommended packages.

An explanation or a PR (e.g. making this behaviour user-configurable) is very welcome.

@Thaodan
Copy link
Contributor

Thaodan commented Feb 29, 2024

An explanation or a PR (e.g. making this behaviour user-configurable) is very welcome.

I haven't tested my idea but I assume that setting the option in zypp.conf, then install a package which has recommends over packagekit should work with the recommends installed.

Setting "the" option would only be possible by writing zypp.conf.

@Olf0
Copy link
Member

Olf0 commented Feb 29, 2024

I haven't tested my idea but I assume that setting the option in zypp.conf, then install a package which has recommends over packagekit should work with the recommends installed.

???
From SailfishOS 3.2.1 installation's /etc/zypp/zypp.conf (this part is equivalent to upstream):

## Whether required packages are installed ONLY
## So recommended packages, language packages and packages which depend
## on hardware (modalias) will not be regarded.
##
## Valid values: boolean
## Default value: false
##
# solver.onlyRequires = false

I.e. the default true is unaltered by SailfishOS' zypp.conf.
BTW, otherwise your statement "Recommends is not merely a hint to the user, pkcon or zypper can handle them and pull recommends by default." would not be true on SailfishOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Is supposed to enhance something
Projects
None yet
Development

No branches or pull requests

3 participants