Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERB being interpreted twice #7

Open
fabriciofreitag opened this issue Mar 6, 2024 · 0 comments
Open

ERB being interpreted twice #7

fabriciofreitag opened this issue Mar 6, 2024 · 0 comments

Comments

@fabriciofreitag
Copy link

Debugging my application I realized a partial was being rendered twice, when comparing both backtraces I got:
image
These lines call node.html twice and it triggers the interpretation of erb partials twice:

    # lib/storyblok/richtext/html_renderer.rb
        elsif node and node.html   # 100 on 0.0.6
          html.push(node.html)       # 101 on 0.0.6

Suggested fix, changing these to:

        elsif node and (node_html = node.html)
          html.push(node_html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant