Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification of Figma changes #71

Open
MoistCode opened this issue Sep 24, 2020 · 2 comments
Open

Notification of Figma changes #71

MoistCode opened this issue Sep 24, 2020 · 2 comments
Labels
category: feature New feature or request help wanted Extra attention is needed

Comments

@MoistCode
Copy link

Is there a way to notify Storybook that there were changes to the Figma design for a component since it was last visited?

@pocka
Copy link
Collaborator

pocka commented Sep 25, 2020

Currently, no.

But I think it's super useful if we can solve that "oh you changed the design spec silently!?" problem with this addon 😝

It's hard or impossible to detect differences from the last time visited because the Figma preview is sandboxed (I mean, iframe). The idea I came up with to overcome this limitation, is saving a rendered image fetched via API or a hash of it with CLI then compare it with the previous one (like image snapshot testing).

  1. Developer implements component
  2. Developer runs the snapshot command
  3. Designer updates the design
  4. Developer runs the snapshot command, changes detected

What do you think? Will that solve your problem?
If anyone has ideas, please feel free to comment on here!

@pocka pocka added category: feature New feature or request help wanted Extra attention is needed labels Sep 25, 2020
@MoistCode
Copy link
Author

Using a hash to compare is a great idea and might be one that I entertain in the future when time permits. There were two other approaches that are floating up in the air for me. Mabl has visual testing capabilities which can be used and Chromatic seems like it might be worth it to look into integrating with this add-on. I'll post on here as I come across anymore ideas and/or discoveries.

@pocka pocka added this to the v6.1 milestone May 7, 2021
@pocka pocka removed this from the v6.1 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants