Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): exclude browser mode iframe results #6905

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(coverage): exclude browser mode iframe results #6905

merged 1 commit into from
Nov 18, 2024

Conversation

AriPerkkio
Copy link
Member

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio force-pushed the fix/coverage-browser-exlucde-tests branch from d5ff3ea to 8629403 Compare November 14, 2024 10:32
@AriPerkkio AriPerkkio force-pushed the fix/coverage-browser-exlucde-tests branch from 8629403 to 70fd42e Compare November 14, 2024 10:32
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d5ff3ea
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6735d195bffb4300082c9df0
😎 Deploy Preview https://deploy-preview-6905--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 14, 2024

@vitest/browser

pnpm add https://pkg.pr.new/@vitest/browser@6905

@vitest/coverage-istanbul

pnpm add https://pkg.pr.new/@vitest/coverage-istanbul@6905

@vitest/coverage-v8

pnpm add https://pkg.pr.new/@vitest/coverage-v8@6905

@vitest/expect

pnpm add https://pkg.pr.new/@vitest/expect@6905

@vitest/mocker

pnpm add https://pkg.pr.new/@vitest/mocker@6905

@vitest/pretty-format

pnpm add https://pkg.pr.new/@vitest/pretty-format@6905

@vitest/runner

pnpm add https://pkg.pr.new/@vitest/runner@6905

@vitest/snapshot

pnpm add https://pkg.pr.new/@vitest/snapshot@6905

@vitest/spy

pnpm add https://pkg.pr.new/@vitest/spy@6905

@vitest/ui

pnpm add https://pkg.pr.new/@vitest/ui@6905

@vitest/utils

pnpm add https://pkg.pr.new/@vitest/utils@6905

vite-node

pnpm add https://pkg.pr.new/vite-node@6905

@vitest/web-worker

pnpm add https://pkg.pr.new/@vitest/web-worker@6905

vitest

pnpm add https://pkg.pr.new/vitest@6905

@vitest/ws-client

pnpm add https://pkg.pr.new/@vitest/ws-client@6905

commit: 70fd42e

@AriPerkkio AriPerkkio marked this pull request as ready for review November 14, 2024 14:24
@AriPerkkio
Copy link
Member Author

/ecosystem-ci run

@vitest-ecosystem-ci
Copy link

vitest-ecosystem-ci bot commented Nov 14, 2024 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
aria-live-capture ✅ success
nuxt ❌ failure
nuxt-test-utils ❌ failure
elk ✅ success
effect ✅ success
lerna-lite ✅ success
zustand ✅ success
vue ✅ success
vite ✅ success
vitest-vscode ❌ failure
vitest-sonar-reporter ✅ success
vitest-github-actions-reporter ✅ success
vitest-browser-simple ✅ success
vitest-browser-examples ❌ failure
vitest-coverage-large ✅ success
vitest-reporters-large ✅ success
vitest-benchmark-large ✅ success

@sheremet-va sheremet-va merged commit e04a136 into vitest-dev:main Nov 18, 2024
18 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-browser-exlucde-tests branch November 18, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
cr-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Weird coverage report
2 participants
@AriPerkkio @sheremet-va