Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee middleware should have assertions. #154

Closed
DavidNix opened this issue Jun 21, 2022 · 4 comments
Closed

Fee middleware should have assertions. #154

DavidNix opened this issue Jun 21, 2022 · 4 comments

Comments

@DavidNix
Copy link
Contributor

See cosmos/ibc-go#396 for ibc-go's manual QA test plan.

As of this writing, this story is likely blocked because:

  • Still in active development for ibc-go.
  • cosmos/relayer support
@DavidNix
Copy link
Contributor Author

We may need to expose ways to get the relayer address.

Per ibc-go team:

I wanted to to do some assertions on relayer accounts. I didn't see a way of getting the relayer addresses. We're working on packet incentivization which requires registering a relayer address on the counter party chain.

@DavidNix
Copy link
Contributor Author

DavidNix commented Jun 21, 2022

Confirmed this is still under active development in ibc-go team.

@jonathanpberger jonathanpberger changed the title Add fee middleware assertions Fee middleware should have assertions. Mar 20, 2023
@Reecepbcups
Copy link
Member

Reecepbcups commented May 10, 2024

No one uses the Fee Module, does not make sense to add verifications for despite being in prod for over a year now. no adoption or UIs. At least 2 years out.

Checks should be upstream in relayer vs interchaintest

@Reecepbcups Reecepbcups closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants