Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrently running test cases should not be flaky when using interchain security. #395

Closed
jtieri opened this issue Feb 13, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jtieri
Copy link
Member

jtieri commented Feb 13, 2023

When running multiple test cases in parallel that utilize interchain security there seems to be some flakiness around the initialization of the provider and consumer chains. Sometimes initialization completely fails, see logs below, and sometimes the channel creation takes so long that you effectively need to wait for 10-20 blocks before you can make any assertions around things like channel state or the ability to relay ibc packets.

Logs:

Error:          Received unexpected error:
                failed to start chains: failed to start provider chain gaia-7: proposal status did not change to passed in expected number of blocks: proposal status (PROPOSAL_STATUS_REJECTED) does not match expected: (PROPOSAL_STATUS_PASSED)
Test:           TestIBCSwapMiddleware_FailRefund
@jtieri jtieri added the bug Something isn't working label Feb 13, 2023
@jonathanpberger jonathanpberger changed the title flakiness in concurrently running test cases when using interchain security Concurrently running test cases should not be flaky when using interchain security. Mar 20, 2023
@boojamya boojamya linked a pull request Apr 21, 2023 that will close this issue
@boojamya boojamya removed a link to a pull request Apr 21, 2023
@Reecepbcups
Copy link
Member

I do not think this is an issue in the v7 branch anymore, should be the same for v8.

@Reecepbcups
Copy link
Member

Reecepbcups commented May 10, 2024

no longer an issue w/ ICS in parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants