refactor(v8): make internal/ public
#1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Reecepbcups
changed the title
internal/ publicinternal/ public
Reecepbcups
changed the title
internal/ publicinternal/ public
joelsmith-2019
approved these changes
Apr 9, 2024
Reecepbcups
added a commit
that referenced
this pull request
Apr 28, 2024
Reecepbcups
added a commit
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #869
Summary
Many teams (including myself) have needed internal logic. This is useful to share for docker, file writers, etc. for test interaction. Since this is a testing framework, I feel it is valid to do so vs copy pasting (bad UX). Some private methods were also make public for external usage without the parent wrapper logic (883f747).
TODO:
Backport to v7 manually