Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .github/workflows/lint.yml to use Go 1.23 and more recent version of golanci-lint #54

Closed
jtieri opened this issue Oct 28, 2024 · 0 comments · Fixed by #55
Closed

Update .github/workflows/lint.yml to use Go 1.23 and more recent version of golanci-lint #54

jtieri opened this issue Oct 28, 2024 · 0 comments · Fixed by #55
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@jtieri
Copy link
Contributor

jtieri commented Oct 28, 2024 •
edited
Loading

We should update the linter GitHub workflow file to use Go version 1.23 and also use the latest version of golanci-lint-action, which i believe is 6.1.1.

Ex:

This

      - name: golangci-lint
        uses: golangci/[email protected]
        with:
          version: v1.57.2
          args: --timeout 15m

should become this

      - name: golangci-lint
        uses: golangci/[email protected]
        with:
          version: v1.61.0
          args: --timeout 15m
@jtieri jtieri added the github_actions Pull requests that update GitHub Actions code label Oct 28, 2024
@jtieri jtieri mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
1 participant
@jtieri