docs: update CODEOWNERS file to use the eng-general-maintainers team #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CODEOWNERS to use the engineering general maintainers team so that way the entire org is not getting alerts for activity in the OSS template repo.
joelsmith-2019
approved these changes
May 29, 2024
That is a great question. Picking two members of the team for code review but only requiring approval from one could be a good way to ensure that PRs are being reviewed quickly. In the past we have only ever had it select one reviewer but I'm not opposed to this. @beckettsean do you have any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CODEOWNERS to use the engineering general maintainers team so that way the entire org is not getting alerts for activity in the OSS template repo.
At the same time I have adjusted the settings on the
eng-general-maintainersteam so that for each PR a random member of the team will be selected for code review. When a member from the team is selected it will only send notifications to the selected team member instead of the entire team. We will make use of theload balancealgorithm which attempts to balance the load across the entire team by taking in account the current number of PRs assigned to each member of the team. see: https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#routing-algorithmsCloses #27