BUG: Approvals Addon – Member Loses Access On Cancellation With PayPal RP

[tictag]

MODS ONLY Relates to support ticket: https://www.paidmembershipspro.com/forums/topic/bug-approvals-addon-member-loses-access-on-cancellation-with-paypal-rp

Describe the bug
With the Reason For Cancelling Addon installed, if a member cancels their PMPro subscription where an active PayPal Recurring Payment exists, their membership is end-dated to the current billing period instead of being cancelled outright.

This works fine (and is the preferred behaviour), except when the membership level requires approval. In this case, the member effectively immediately looses access because their ‘new’ membership again requires approval.

So the website tells them one thing, but then actually does something else.

To Reproduce
Please review this screencast showing step-by-step how to re-create this issue: https://1drv.ms/u/s!AiwD9-8HyNC59wHqUVTL8AjBjyNy?e=MiykJy

Screenshots
As above

Expected behavior
PMPro is consistent with its own messages.

WordPress Environment
PHP v7.3.20
WordPress v5.5.1
PMPro v2.5.1
Approvals Addon v1.3.4
Reason For Cancelling Addon v0.2

[andrewlimaza]

This sounds like an issue with Cancel on Next Payment Date Add On.

This gist may be used to automatically approve any pre-approved members: https://gist.github.com/andrewlimaza/cc30cf628a31805a40fe62d14a2309ae