Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(events): Mathcing data params in server-side plugin-config example with client-side data params of custom events #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(events): Mathcing data params in server-side plugin-config example with client-side data params of custom events #96

wants to merge 1 commit into from

Conversation

prithvi2k2
Copy link

The server-side code should include id as receivable data along with name - this then matches the data entities sent by the client and id was also used in the server code without prior definition. Let me know if I'm wrong, I didn't test it locally.

Description

Added id param to custom events example config to match the event proto of client

Type of change

  • Documentation (updates to the documentation or readme)
  • Bug fix (a non-breaking change that fixes an issue)
  • Enhancement (improving an existing functionality like performance)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Relevant Issue(s)

@prithvi2k2
Mathcing data params in server-side example
f4db13e 
The server-side code should include ìd` as receivable data along with `name` - this then matches the data entities sent by the client and `id` is also used in the server code.
Let me know if I'm wrong, I didn't test it locally.
@prithvi2k2 prithvi2k2 changed the title docs: Mathcing data params in server-side example for custom events' plugin config docs(events): Mathcing data params in server-side example for custom events' plugin config Jul 8, 2024
@prithvi2k2 prithvi2k2 changed the title docs(events): Mathcing data params in server-side example for custom events' plugin config docs(events): Mathcing data params in server-side plugin-config example with client-side data params of custom events Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prithvi2k2