This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add option for skipping Git working tree check #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dennisameling thank you for the pull request, I will try to review it before the end of the week. |
markkaylor
suggested changes
Aug 31, 2022
| @@ -13,7 +13,7 @@ const { migratePlugin, migrateApiFolder, migrateDependencies, migrateApplication | |||
| // Global utils | |||
| const { isPathStrapiApp, logger, isCleanGitRepo, promptUser } = require('../../lib/global/utils'); | |||
|
|
|||
| const migrate = async (type, path, pathForV4Plugin) => { | |||
| const migrate = async (type, path, pathForV4Plugin, cliOptions) => { | |||
There was a problem hiding this comment.
I think we should change this to accept an object {type, path, pathForV4Plugin, cliOptions}
| .action(async (path) => { | ||
| await migrate('application', path); | ||
| .action(async (path, options) => { | ||
| await migrate('application', path, undefined, options); |
There was a problem hiding this comment.
See my other comment, then here: {type: 'application', path, cliOptions: options}
There was a problem hiding this comment.
and you will have to make the update anywhere else migrate is called
remidej
added
the
pr: enhancement
|
Since there has been no update to this PR I'm going to mark it as closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37. Happy to take a different approach if the team prefers that. This at least unblocked my workflow!