Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles_logic_sv2: refactor utils module #1448

Open
GitGab19 opened this issue Feb 4, 2025 · 3 comments
Open

roles_logic_sv2: refactor utils module #1448

GitGab19 opened this issue Feb 4, 2025 · 3 comments
Assignees
@plebhash
Labels
refactor Implies refactoring code roles-logic-sv2
Milestone
1.3.0

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented Feb 4, 2025

This module has the following issues to be tackled:

  • it contains several public functions which are only used internally, so probably some of them should be made private.
  • utils::get_target is not used anywhere, therefore it should be cleaned up from the codebase
  • utils::Id and utils::GroupId feel like they belong to modules related to channels and job logic
@GitGab19 GitGab19 added refactor Implies refactoring code roles-logic-sv2 labels Feb 4, 2025
@GitGab19 GitGab19 added this to the 1.3.0 milestone Feb 4, 2025
@plebhash

This comment has been minimized.

Sign in to view
@plebhash plebhash mentioned this issue Feb 9, 2025
Merged
@plebhash
Copy link
Collaborator

plebhash commented Feb 9, 2025 •
edited
Loading

#1268 (comment)

@Shourya742

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plebhash plebhash

Labels
refactor Implies refactoring code roles-logic-sv2
Projects
SV2 Roadmap 🛣️
Status: Todo 📝
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@GitGab19 @Shourya742 @plebhash