Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to standardize dependency (and API re-exporting) patterns #1458

Open
plebhash opened this issue Feb 5, 2025 · 0 comments
Open

need to standardize dependency (and API re-exporting) patterns #1458

plebhash opened this issue Feb 5, 2025 · 0 comments
Labels
refactor Implies refactoring code roles Pertains to all roles

Comments

@plebhash
Copy link
Collaborator

plebhash commented Feb 5, 2025

currently most of the roles crates import crates from protocols in a redundant way

ideally, crates like network_helpers_sv2 and roles_logic_sv2 should re-export all the needed items, and we should avoid redundant imports on roles

for example: a role shouldn't really need to declare codec_sv2 as an explicit dependency... that should be an explicit dependency for network_helpers_sv2, and if role needs some API from codec_sv2, network_helpers_sv2 should simply re-export it

@plebhash plebhash added refactor Implies refactoring code roles Pertains to all roles labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implies refactoring code roles Pertains to all roles
Projects
None yet
Development

No branches or pull requests

1 participant