Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the binary_sv2 crate. #1462

Open
Shourya742 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #1463
Open

Restructure the binary_sv2 crate. #1462

Shourya742 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #1463

Comments

@Shourya742
Copy link
Contributor

The current structure of binary_sv2 does not follow best practices. Typically, a crate defining a proc_macro only includes an additional crate for the macro’s implementation. However, in binary_sv2, we have two separate crates—one for the proc_macro implementation and another for the primitives required for macro scaffolding. Due to the tightly coupled nature of the proc_macro implementation with the module structure, restructuring it requires rewriting some parts of the macro to align with the proposed design.

Kudos to @plebhash for pointing this out and suggesting a better structure: #1459 (comment)

@Shourya742 Shourya742 linked a pull request Feb 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant