You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current structure of binary_sv2 does not follow best practices. Typically, a crate defining a proc_macro only includes an additional crate for the macro’s implementation. However, in binary_sv2, we have two separate crates—one for the proc_macro implementation and another for the primitives required for macro scaffolding. Due to the tightly coupled nature of the proc_macro implementation with the module structure, restructuring it requires rewriting some parts of the macro to align with the proposed design.
The current structure of
binary_sv2
does not follow best practices. Typically, a crate defining aproc_macro
only includes an additional crate for the macro’s implementation. However, inbinary_sv2
, we have two separate crates—one for theproc_macro
implementation and another for the primitives required for macro scaffolding. Due to the tightly coupled nature of theproc_macro
implementation with the module structure, restructuring it requires rewriting some parts of the macro to align with the proposed design.Kudos to @plebhash for pointing this out and suggesting a better structure: #1459 (comment)
The text was updated successfully, but these errors were encountered: