backup_faves.php runs out of memory

[mojodna]

My memory_limit = 32M (in /etc/php5/cli/php.ini), what's yours?

Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 14158845 bytes) in /home/seth/www/parallel-flickr/www/include/lib_http.php on line 238

[mncaudill]

My thought is that 32 megabytes should be enough for anyone (to paraphrase Mr. Gates), but maybe that's not the case. My instinct was that there was a place where a good unset would have fixed things, but I ran xdebug and xhprof over the backup_faves script and nothing jumped out at me.

I'll try to poke some more tonight if I can find the leak, or if it's not a leak, figure out how to keep less stuff in memory at one time (which may just be the whole issue).

[mojodna]

I switched it fairly arbitrarily to 128M and it's been running beautifully.

[straup]

Yeah, this one puzzles me. The basic change is around the pre-bucketing of contact hashes in an array during the fetch from the Flickr API and then adding them one at a time.

Previously they would be added as they were retrieved because the old set (of contacts) had already been purged from the database.

That just doesn't seem like the kind of thing to make the memory requirements go all loopy. The only other notable change is the retry code for the Flickr API but, again, that just doesn't seem likely.

Which leaves something squirrel-y happening in a while loop but I can't see it yet...