Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove folders created for service groupings #3023

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

jar-stripe
Copy link
Contributor

@jar-stripe jar-stripe commented Oct 30, 2024

Why?

The code generator had previously generated pluralized folders for V2 services that only contain other services, like V2/Billings, V2/Cores, V2s, etc. This is undesirable because it produces a confusing directory structure. This PR moves the files out of these folders after modifying the code generator to treat these services like namespaces instead of resource-ful services.

This is not a breaking change as the C# namespaces are not changed.

What?

  • moves services out of V2/Cores, and V2/Billings into V2 folder and deletes subfolders
  • moves V2Services out of V2S into Stripe.net/Services and removes V2S folder

See also

http://go/j/DEVSDK-2196

@jar-stripe jar-stripe enabled auto-merge (squash) November 4, 2024 20:14
@jar-stripe jar-stripe merged commit bb87579 into master Nov 4, 2024
4 checks passed
@jar-stripe jar-stripe deleted the jar/fix-naming-discrepancies branch November 4, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants