Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit connecting with an alternative authcid #113

Merged
merged 2 commits into from
Apr 14, 2015

Conversation

benlangfeld
Copy link
Contributor

This permits imitation of other users (for example, if [email protected] is allowed to create a session as [email protected], he will provide the JID [email protected] in <stream:stream to="..." and , but use his own credentials in the the packet per SASL's separation of authzid and authcid.

This permits imitation of other users (for example, if [email protected] is allowed to create a session as [email protected], he will provide the JID [email protected] in <stream:stream to="..." and <bind/>, but use his own credentials in the the <auth/> packet per SASL's separation of authzid and authcid.
benlangfeld added a commit to benlangfeld/strophejs-plugins that referenced this pull request Apr 14, 2015
@benlangfeld
Copy link
Contributor Author

This appears to work well for me on ejabberd. Any chance it could be merged?

jcbrand added a commit that referenced this pull request Apr 14, 2015
Permit connecting with an alternative authcid
@jcbrand jcbrand merged commit 72914b8 into strophe:master Apr 14, 2015
jcbrand added a commit to strophe/strophejs-plugins that referenced this pull request Apr 14, 2015
@jcbrand
Copy link
Contributor

jcbrand commented Apr 14, 2015

Hi @benlangfeld, I'm curious, what's the usecase for this? Is it for users who have multiple XMPP accounts?

@benlangfeld
Copy link
Contributor Author

Either for proxy authentication in general (maybe a set of credentials give access to multiple accounts, maybe certain users can masquerade as other users for testing purposes) or, in my case, to support MojoAuth.

@benlangfeld
Copy link
Contributor Author

Is there a particular schedule for a 1.2.3 release, @jcbrand, or would it be appropriate to request that here?

@benlangfeld benlangfeld deleted the feature/alternative-authcid branch April 14, 2015 20:17
@jcbrand
Copy link
Contributor

jcbrand commented Apr 15, 2015

So far there aren't many new changes since the last release (1.2.1).

I'm however happy to make a new release for you if you need it.

@benlangfeld
Copy link
Contributor Author

Only so that Candy can depend on a final release. No big deal :)

@benlangfeld
Copy link
Contributor Author

Put a freeze on that request, @jcbrand. I'm having trouble updating Candy to 1.2.1 anyway.

sualko pushed a commit to strophe/strophejs-plugin-roster that referenced this pull request Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants