Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 16 KB page sizes #1476

Open
yiliyunfan opened this issue Feb 24, 2025 · 3 comments
Open

Support 16 KB page sizes #1476

yiliyunfan opened this issue Feb 24, 2025 · 3 comments

Comments

@yiliyunfan
Copy link

https://developer.android.com/guide/practices/page-sizes

@bradh
Copy link
Contributor

bradh commented Feb 24, 2025

Can you say what the actual problem is? I don't think that libheif provides Android binaries, and your link doesn't seem to identify any source-relevant issues.

@farindk
Copy link
Contributor

farindk commented Feb 24, 2025

Actually, there is a script to build Android binaries: https://github.com/strukturag/libheif/blob/master/scripts/build-android-libs.sh
I use that in my own Android software. But the required flags depend on the NDK version, so you have to adapt this script anyways. I also do not see what change in libheif is expected...

@silverbacknet
Copy link
Contributor

It looks like adding target_link_options(${CMAKE_PROJECT_NAME} PRIVATE "-Wl,-z,max-page-size=16384") to that is all you can do for NDK 27 and below, and anything above it's automatic. The rest is up to the compiler, packager, and the OS to handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants