Add web person page #252
Merged
Add web person page #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladtf
reviewed
Aug 19, 2021
IoanaAlexandru
requested changes
Aug 20, 2021
If this is a trivial change that doesn't warrant a test or changelog entry, you can mark it as #trivial in the PR title. Generated by 🚫 Danger |
…upb-mobile into web/layout/profile_view_people
RazvanRotaru
requested changes
Sep 24, 2021
…/profile_view_people # Conflicts: # lib/pages/classes/view/classes_page.dart # lib/pages/people/view/person_view.dart
RazvanRotaru
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-redesign person_view page
-center the cards in the page
-fix bug with the avatar image (resize after the page scale, now it is fixed image)
-add scrollbar in case of too many courses (must be extracted in another widget)