Error page for admin panel #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a new illustration * show an error page if you dont have permissions to see admin panel content
If this is a trivial change that doesn't warrant a test or changelog entry, you can mark it as #trivial in the PR title. Generated by 🚫 Danger |
IoanaAlexandru
requested changes
Mar 13, 2022
| @@ -145,6 +145,7 @@ | |||
| "errorInsertGoogleEvents": "Unable to insert events in Google Calendar.", | |||
| "errorLoadRequests": "Could not load requests", | |||
| "errorUnknownUser": "Unknown User", | |||
| "errorDontHavePermissions": "You don't have permission to access this page.", | |||
There was a problem hiding this comment.
Nit: rename to "errorNoPermissions"
Comment on lines
+84
to
+88
| if (user.isAdmin) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (user.isAdmin) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| return user.isAdmin; |
| } | ||
|
|
||
| bool checkUserIsAdmin() { | ||
| final authProvider = Provider.of<AuthProvider>(context, listen: false); |
There was a problem hiding this comment.
I believe listen: false isn't necessary here. (also now that I look at it it's probably not necessary above either, for the admin provider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error page if you don't have permission to see admin panel content.