Code refactoring

[faboschert]

This issue is for collecting places in our code that can be optimized:

• Redundant code:
  • some functions in LdapAdapter
  • error/warning/success messages in login.twig / base.twig
  • password validation in PasswordRecoveryControllerProvider.php / index.php
• Code to split:
  • index.php

[leomelzer]

• Properly abstract templates (see "login" and "base").
• Modularize Javascript where it makes sense
• Move index.php code to separate Controllers, as you suggested
• Extract validation for $ownerPermission etc (see GuestControllerProvider.php) in before() middleware

[leomelzer]

Password validation is now somewhat shared in

dashboard/app/sog/Dashboard/DataUtilityServiceProvider.php

Line 23 in 55c2630

private static function checkPasswordPolicy($password, $minLength = 8, $regex = '/[A-Za-z].*[0-9]|[0-9].*[A-Za-z]/')

[leomelzer]

Group-related code should be moved to new https://github.com/studieren-ohne-grenzen/dashboard/blob/develop/app/sog/Dashboard/GroupControllerProvider.php

[leomelzer]

Move generation of buttons (and possibly other reusable components) to Twig Macros

[leomelzer]

This is RE #27 (comment) but it better fits here:

I had the same thought yesterday – I think we should just pass UIDs or OUs to the LdapAdapter and it will figure out what to do with it, e.g. retrieving the full respective DN first. This better fits the traditional model of passing primary keys to some sort of database abstraction layer.