Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with custom fieldHandle #94

Closed
kffein-david opened this issue May 22, 2024 · 4 comments
Closed

issue with custom fieldHandle #94

kffein-david opened this issue May 22, 2024 · 4 comments
Assignees

Comments

@kffein-david
Copy link

When using custom fieldHandle to name an seo field, then there is an error in SitemapService.php

Steps to reproduce:

1- give your seo field the handle "commons_seo"

2- in config/seo-fields.php specify the custom handle:

return [
	"fieldHandle" => "commons_seo",
];

3- check you sitemap ( not the sitemap index but a detailled one)

result:
Getting unknown property: craft\elements\Entry::seo

coming from SitemapService.php

if ($entry->**seo**->allowIndexing === 'no') {
     continue;
}

CraftCMS version: 5.1.4
Plugin version: 5.0.0-beta.1

@janhenckens
Copy link
Member

Hey @kffein-david

Thanks for reporting that! Looks like I'm not taking the plugin handle into account correctly there. I'll try to have a fix out by the end of the week!

@kffein-david
Copy link
Author

kffein-david commented May 22, 2024 via email

@janhenckens
Copy link
Member

Fix is out in 5.0.0 - Can you update and give it another try @kffein-david?

@kffein-david
Copy link
Author

kffein-david commented May 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants