5.2.1 crashed

[GoodMirek]

Please find crash report attached. It is possible that the crash was caused by a break in attempt, as the machine is publicly accessible.
OSXvnc-server_2018-03-10-125853_administrators-Mac-mini.crash.gz

It is not helpful that VineServer.log is overwritten instead of appended upon every start of the server.

[stweil]

It is not helpful that VineServer.log is overwritten instead of appended upon every start of the server.

At least that part should be easy to fix. Thank you for this report.

[GoodMirek]

Another crash happened, possibly a different problem, not sure whether to open a different issue or not. Attaching crash report. Crash happened within several seconds after connecting with VNC client. VNC client in use is Remmina (remmina-1.2.0-0.45.20180107.git.d70108c.fc27.x86_64), OS Linux Fedora Core 27.
OSXvnc-server_2018-03-14-085308_administrators-Mac-mini.crash.gz

[stweil]

Removing the line numbers 860 ... 864 in VNCController.m should avoid deleting of old log messages. But how can we avoid that VineServer.log grows uncontrolled?

[stweil]

Both crashes are related to dynamic memory allocation (heap). Using heap checkers like Valgrind or linking against a heap checking library like gperftools must be done to narrow down the buggy code.

[GoodMirek]

Is that something you could do or provide instructions how to do that?

On Thu, Mar 15, 2018, 08:34 Stefan Weil ***@***.***> wrote: Both crashes are related to dynamic memory allocation (heap). Using heap checkers like Valgrind or linking against a heap checking library like gperftools must be done to narrow down the buggy code. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#26 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHcWNH26YR1VPwmXhzbAvy2XXFkvijIaks5tehmggaJpZM4SqdD8> .

-- Mirek Svoboda | +420 608 224 486

[stweil]

I did heap debugging with Valgrind on Linux and Windows, but never on macOS. Basically it involves installation ("brew install valgrind") and running OSXvnc under supervision by Valgrind (start the service from the command line and prefix the command with valgrind).

[stweil]

This issue might be related to issue #48. Perhaps it is fixed in the latest release.