Add support for boolean values for theme.variants #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the docs dont explicitly say otherwise, I assumed that boolean values would work as keys in the
values
object passed totheme.variants()
. After some debugging and looking through the source I realized this wasnt possible because of a conditional that checked if the value's key was truthy.These changes explicitly check if the value's key is undefined, which allows props passed to the styled Component to be boolean values.
Example usage: