-
Notifications
You must be signed in to change notification settings - Fork 167
Comparing changes
Open a pull request
base repository: substrait-io/substrait
base: bc4d6fb9bc0435c3db24172566c343e119fc50a9
head repository: substrait-io/substrait
compare: 297715c7b7b6cb367973cc64c1a2a296df12a812
- 7 commits
- 10 files changed
- 7 contributors
Commits on Sep 19, 2024
-
chore(deps): Bump bufbuild/buf-setup-action from 1.41.0 to 1.42.0 (#709)
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.41.0 to 1.42.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1f3354d - Browse repository at this point
Copy the full SHA 1f3354dView commit details
Commits on Sep 27, 2024
-
feat: change grouping expressions in AggregateRel to references (#706)
BREAKING CHANGE: This PR changes the definition of grouping sets in `AggregateRel` to consist of references into a list of grouping expressions instead of consisting of expressions directly. With the previous definition, consumers had to deduplicate the expressions in the grouping sets in order to execute the query or even derive the output schema (which is problematic, as explained below). With this change, the responsibility of deduplicating expressions is now on the producer. Concretely, consumers are now expected to be simpler: The list of grouping expressions immediately provides the information needed to derive the output schema and the list of grouping sets explicitly and unambiguously provides the equality of grouping expressions. Producers now have to specify the grouping sets explicitly. If their internal representation of grouping sets consists of full grouping expressions (rather than references), then they must deduplicate these expressions according to their internal notion of expression equality in order to produce grouping sets consisting of references to these deduplicated expressions. If the previous format is desired, it can be obtained from the new format by (1) deduplicating the grouping expressions (according to the previously applicable definition of expression equality), (2) re-establishing the duplicates using the emit clause, and (3) "dereferencing" the references in the grouping sets, i.e., by replacing each reference in the grouping sets with the expression it refers to. The previous version was problematic because it required the *consumers* to deduplicate the expressions from the grouping sets. This, in turn, requires to parse and understand 100% of these expression even in cases where that understanding is otherwise optional, which is in opposition to the general philosophy of allowing for simple-minded consumers. The new version avoids that problem and, thus, allows consumers to be simpler. The issues are discussed in even more detail in #700. --------- Signed-off-by: Ingo Müller <ingomueller@google.com> Co-authored-by: Weston Pace <weston.pace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65a7d38 - Browse repository at this point
Copy the full SHA 65a7d38View commit details -
feat: clarify behaviour of SetRel operations (#708)
Clarified language of existing SetRel operations to distinguish ALL and DISTINCT behaviour. Added language around ALL versions of operations to better specify how many versions of a record should appear in the relation output. feat: added SET_OP_MINUS_PRIMARY_ALL feat: added SET_OP_INTERSECTION_MULTISET_ALL These operations corresponds to SQL: * EXCEPT ALL * INTERSECT ALL
Configuration menu - View commit details
-
Copy full SHA for f796521 - Browse repository at this point
Copy the full SHA f796521View commit details
Commits on Oct 1, 2024
-
feat: make substrait repo a go module (#712)
This facilitates substrait assets use in go projects
Configuration menu - View commit details
-
Copy full SHA for 3dca9b5 - Browse repository at this point
Copy the full SHA 3dca9b5View commit details -
chore(deps): Bump bufbuild/buf-setup-action from 1.42.0 to 1.43.0 (#717)
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.42.0 to 1.43.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bufbuild/buf-setup-action/releases">bufbuild/buf-setup-action's releases</a>.</em></p> <blockquote> <h2>v1.43.0</h2> <p>Release v1.43.0</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bufbuild/buf-setup-action/commit/62ee92603c244ad0da98bab36a834a999a5329e6"><code>62ee926</code></a> Release v1.43.0 (<a href="https://redirect.github.com/bufbuild/buf-setup-action/issues/226">#226</a>)</li> <li>See full diff in <a href="https://github.com/bufbuild/buf-setup-action/compare/v1.42.0...v1.43.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a6ef7c0 - Browse repository at this point
Copy the full SHA a6ef7c0View commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0346a83 - Browse repository at this point
Copy the full SHA 0346a83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297715c - Browse repository at this point
Copy the full SHA 297715cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff bc4d6fb9bc0435c3db24172566c343e119fc50a9...297715c7b7b6cb367973cc64c1a2a296df12a812