chore: free sub prices; extra test case

subtopia-algo · Sep 17, 2023 · fb2c5e8 · fb2c5e8
1 parent 4783b39
commit fb2c5e8
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 6 deletions.
diff --git a/src/clients/SubtopiaClient.ts b/src/clients/SubtopiaClient.ts
@@ -315,9 +315,12 @@ export class SubtopiaClient {
     );
   }
 
-  public async getSubscriptionPlatformFee(
-    priceInCents: number
-  ): Promise<number> {
+  public async getSubscriptionPlatformFee(): Promise<number> {
+    if (this.price === 0) {
+      return new Promise((resolve) => resolve(0));
+    }
+
+    const priceInCents = SUBSCRIPTION_PLATFORM_FEE_CENTS;
     const computePlatformFeeAtc = new AtomicTransactionComposer();
     computePlatformFeeAtc.addMethodCall({
       appID: this.oracleID,
@@ -572,9 +575,7 @@ export class SubtopiaClient {
       // @ts-ignore
       oracleAdminState.valueRaw
     );
-    const platformFeeAmount = await this.getSubscriptionPlatformFee(
-      SUBSCRIPTION_PLATFORM_FEE_CENTS
-    );
+    const platformFeeAmount = await this.getSubscriptionPlatformFee();
     const creatorLockerId = await SubtopiaRegistryClient.getLocker({
       registryID: TESTNET_SUBTOPIA_REGISTRY_ID,
       algodClient: this.algodClient,

diff --git a/tests/subtopia.test.ts b/tests/subtopia.test.ts
@@ -343,4 +343,54 @@ describe("subtopia", () => {
       timeout: 10e6,
     }
   );
+
+  it(
+    "should not withdraw platform fee for free subscription",
+    async () => {
+      // Setup
+      const { subtopiaRegistryClient, lockerID } =
+        await setupSubtopiaRegistryClient(creatorSignerAccount);
+
+      // Create a new infrastructure with price 0
+      const response = await subtopiaRegistryClient.createInfrastructure({
+        productName: "Freeflix",
+        subscriptionName: "Free",
+        price: 0,
+        subType: SubscriptionType.UNLIMITED,
+        maxSubs: 0,
+        coinID: 0,
+        lockerID: lockerID,
+      });
+
+      // Initialize a new SubtopiaClient
+      const productClient = await SubtopiaClient.init(
+        algodClient,
+        response.infrastructureID,
+        creatorSignerAccount
+      );
+
+      // Subscribe a user to the product
+      const subscriberSigner = transactionSignerAccount(
+        makeBasicAccountTransactionSigner(bobTestAccount),
+        bobTestAccount.addr
+      );
+
+      const subscribeResponse = await productClient.createSubscription({
+        subscriber: subscriberSigner,
+        duration: Duration.UNLIMITED,
+      });
+
+      expect(subscribeResponse.subscriptionID).toBeGreaterThan(0);
+      expect(subscribeResponse.txID).toBeDefined();
+
+      // Get the platform fee
+      const platformFee = await productClient.getSubscriptionPlatformFee();
+
+      // Assert that the platform fee is 0
+      expect(platformFee).toBe(0);
+    },
+    {
+      timeout: 10e6,
+    }
+  );
 });