Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate lib for Security ("Auth"?) module. #547

Closed
jessekelly881 opened this issue Apr 30, 2024 · 4 comments
Closed

Create separate lib for Security ("Auth"?) module. #547

jessekelly881 opened this issue Apr 30, 2024 · 4 comments

Comments

@jessekelly881
Copy link

jessekelly881 commented Apr 30, 2024

The Security lib might work better as a separate (transport layer independent) library that works not only with with effect-http but also with pure @effect/platform http, rpc, and other transport layers. That's how I would like to use it anyway. :)

@sukovanej
Copy link
Owner

Yeah, I already thought about it. That holds for the middlewares like CORS in the codebase as well. Now that I see an outside interest in that, I might actually do it 😄.

@sukovanej
Copy link
Owner

Hey, done within the latest release. Readme, examples and probably some combinators enabling easy integration with a /platform are missing tho.

@jessekelly881
Copy link
Author

Looks fantastic! Thanks @sukovanej. Let me know if you need a hand with it. I'd be happy to help. :)

@sukovanej
Copy link
Owner

We discussed potential merge of this lib to the official effect monorepo. Independently of how that'll turn out, we talked with fubhy about the separation of packages and the result is we should rather aim for a simple setup with a single platform-independent package a few platform-specific ones. So I will very probably merge the effect-http-error and effect-http-security back. effect-http is practically dependency-free, there is @effect/platform, @effect/schema and effect as peer deps so it doesn't really make any difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants