Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GisAssembly/GenerateMods may need better spec coverage #764

Closed
ndushay opened this issue Feb 3, 2024 · 1 comment
Closed

GisAssembly/GenerateMods may need better spec coverage #764

ndushay opened this issue Feb 3, 2024 · 1 comment

Comments

@ndushay
Copy link
Contributor

ndushay commented Feb 3, 2024

(if we're not going to kill this code altogether ... See #707)

from https://codeclimate.com/github/sul-dlss/gis-robot-suite/lib/robots/dor_repo/gis_assembly/generate_mods.rb/source

it may be useful to add tests for

  • geometry_type_ogrinfo of LineString (line 48)
  • raster file_format without tif leads to 'ArcGrid' (lines 58-61) -- if we're still going to deal with ArcGrid ... see issue Convert ArcGrid to GeoTIFF #739
  • find_geometry_type_ogrinfo with Geometry output (lines 79-83)

if those are all super-rare cases in actuality, shrug.

@aaron-collier
Copy link
Contributor

aaron-collier commented Feb 20, 2024

Part of #707

@github-project-automation github-project-automation bot moved this from Blocked to Done in Geo Workcycles 2024 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants