Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider reducing memory usage for ObjectValidator.validate if performance is still a concern #970

Closed
ndushay opened this issue Jun 9, 2022 · 3 comments
Labels
SDR improvements for June-July 2022 work cycle

Comments

@ndushay
Copy link
Contributor

ndushay commented Jun 9, 2022

Performance analysis for discovery reports indicates that ObjectValidator.validate uses a lot of memory. See issue #908

It's possible this work will be less important after #961 is solved.

See also #864, which essentially says "this method needs a refactor anyway"

Can this method be rewritten to reduce the memory footprint?

Approach suggested:

As with #961, the likely culprits would be:

@ndushay ndushay added the SDR improvements for June-July 2022 work cycle label Jun 9, 2022
@ndushay ndushay added the blocked prereqs for this ticket aren't done yet label Jun 14, 2022
@ndushay
Copy link
Contributor Author

ndushay commented Jun 14, 2022

marked blocked until we know if addressing issue #961 is sufficient (PR #965)

@ndushay ndushay added performance and removed blocked prereqs for this ticket aren't done yet labels Jun 23, 2022
@ndushay
Copy link
Contributor Author

ndushay commented Jun 27, 2022

We think PR #965 is sufficent.

@ndushay ndushay changed the title reduce memory usage for ObjectValidator.validate consider reduce memory usage for ObjectValidator.validate if performance is still a concern. Jun 27, 2022
@ndushay ndushay changed the title consider reduce memory usage for ObjectValidator.validate if performance is still a concern. consider reducing memory usage for ObjectValidator.validate if performance is still a concern. Jun 27, 2022
@ndushay ndushay changed the title consider reducing memory usage for ObjectValidator.validate if performance is still a concern. consider reducing memory usage for ObjectValidator.validate if performance is still a concern Jun 27, 2022
@edsu
Copy link
Contributor

edsu commented Aug 9, 2023

@ndushay it looks like this issue can be closed given your last comment?

@ndushay ndushay closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDR improvements for June-July 2022 work cycle
Projects
None yet
Development

No branches or pull requests

2 participants