Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication redis queue names - prefix with replication and match job class name #2064

Open
7 tasks done
ndushay opened this issue Nov 22, 2022 · 1 comment
Open
7 tasks done
Assignees
Labels
refactor architecture, refactoring, style, etc.

Comments

@ndushay
Copy link
Contributor

ndushay commented Nov 22, 2022

from storytime 2022-11-21

(Note this is also about matching the redis queue names with the job class name - see #2063 - assume no classes will have their names changed as a result of that ticketing, for now.)

  • All replication redis queue names should be prefixed with replication_
    • zipmaker should become replication_zipmaker
    • zips_made should become replication_plexer
    • s3_us_east_1_delivery should become replication_aws_us_east_1_delivery (check to be sure we are changing s3 to aws for this job class)
    • s3_us_west_2_delivery should become replication_aws_us_west_2_delivery (check to be sure we are changing s3 to aws for this job class)
    • ibm_us_south_delivery should become replication_ibm_us_south_delivery
    • zip_endpoint_events should become replication_results_recorder

(Analogous ticket for audit queues: #2056)

@ndushay ndushay added the refactor architecture, refactoring, style, etc. label Nov 22, 2022
@ndushay ndushay changed the title Repliation redis queue names - prefix with replication and match job class name Repliation redis queue names - prefix with replication and match job class name Nov 22, 2022
@ndushay ndushay changed the title Repliation redis queue names - prefix with replication and match job class name Replication redis queue names - prefix with replication and match job class name Nov 22, 2022
@ndushay
Copy link
Contributor Author

ndushay commented Jan 12, 2023

Now that we're on sidekiq, this also requires updating the worker allocation configs in shared_configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor architecture, refactoring, style, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants