[HOLD] Rename queues to include replication_ and audit_ in the name #2185
Conversation
aaron-collier
changed the title
aaron-collier
changed the title
aaron-collier
changed the title
aaron-collier
changed the title
| @@ -18,7 +18,7 @@ module Replication | |||
| # the VM is updated to a new vesrion). Therefore, we receive the zip | |||
| # metadata from the process that actually created the zip file. | |||
| class DeliveryDispatcherJob < Replication::ZipPartJobBase | |||
| queue_as :zips_made | |||
| queue_as :replication_plexer | |||
There was a problem hiding this comment.
Can we call delivery dispatcher? We're deprecating "plexer".
There was a problem hiding this comment.
yeah - that was from the ticket which was written before this class changed. So I agree with JLitt's request: replication_delivery_dispatcher.
There was a problem hiding this comment.
How do you feel about that suggestion @ndushay? I made these based on the ticket.
There was a problem hiding this comment.
I wrote the ticket and it was out of date. Sorry about that.
aaron-collier
changed the title
| @@ -18,7 +18,7 @@ module Replication | |||
| # the VM is updated to a new vesrion). Therefore, we receive the zip | |||
| # metadata from the process that actually created the zip file. | |||
| class DeliveryDispatcherJob < Replication::ZipPartJobBase | |||
| queue_as :zips_made | |||
| queue_as :replication_plexer | |||
There was a problem hiding this comment.
yeah - that was from the ticket which was written before this class changed. So I agree with JLitt's request: replication_delivery_dispatcher.
| @@ -6,7 +6,7 @@ module Replication | |||
| # Please update the configs for the various environments if it's renamed or moved. | |||
| # @note This name is slightly misleading, as this class solely deals with AWS US East 1 endpoint | |||
| class S3EastDeliveryJob < Replication::DeliveryJobBase | |||
| queue_as :s3_us_east_1_delivery | |||
| queue_as :replication_aws_us_east_1_delivery | |||
There was a problem hiding this comment.
again, follow the job name, not the ticket.
| @@ -6,7 +6,7 @@ module Replication | |||
| # Please update the configs for the various environments if it's renamed or moved. | |||
| # @note This name is slightly misleading, as this class solely deals with AWS US West 2 endpoint | |||
| class S3WestDeliveryJob < Replication::DeliveryJobBase | |||
| queue_as :s3_us_west_2_delivery | |||
| queue_as :replication_aws_us_west_2_delivery | |||
There was a problem hiding this comment.
again, follow the job name, not the ticket.
aaron-collier
force-pushed
the
2064-rename-queues
branch
from
740e1e9 to
af3065d
Compare
|
@aaron-collier just a gentle reminder this is still outstanding; perhaps next week when you're FR? |
Why was this change made? 🤔
Closes #2064 by renaming the replication job queues.
Closes #2056 by renaming the audit job queues.
When merging note the required shared configs PRs: https://github.com/sul-dlss/shared_configs/pulls/aaron-collier
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, or if it changes code used internally for cloud replication, run integration test preassembly_image_accessioning_spec.rb against stage as it tests preservation, and/or test in stage environment, in addition to specs. The main classes relevant to replication are
ZipmakerJob,DeliveryDispatcherJob,*DeliveryJob,ResultsRecorderJob, andDruidVersionZip; see here for overview diagram of replication pipeline.⚡