Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review rescue and raise conventions in bots #67

Open
atz opened this issue Apr 18, 2018 · 0 comments
Open

Review rescue and raise conventions in bots #67

atz opened this issue Apr 18, 2018 · 0 comments
Labels

Comments

@atz
Copy link
Contributor

atz commented Apr 18, 2018

for example: transfer-object raises ItemError in some private methods, but then catches it in perform and re-raises an ItemError.

Also - when is it valuable to wrap an error/exception in ItemError? Possibly only when we want to add some context to be passed on to caller (to ultimately show up in Argo, for example). @atz says why differentiate errors if the caller doesn't care? So we can just let some errors propagate ... but hopefully we know if the thrown errors have enough info to be useful.

@ndushay ndushay changed the title Review rescue and raise convention in bots Review rescue and raise conventions in bots Apr 18, 2018
@ndushay ndushay added ready and removed backlog labels Apr 18, 2018
@ndushay ndushay added ready and removed backlog labels May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants