Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item_comment no longer appears to be used. #1539

Closed
jcoyne opened this issue Jun 28, 2023 · 2 comments
Closed

item_comment no longer appears to be used. #1539

jcoyne opened this issue Jun 28, 2023 · 2 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Jun 28, 2023

requests_with_item_comment = Request.select { |req| req.data['item_comment'] }
 =>
[#<MediatedPage:0x00007f7018f8e078
...
requests_with_item_comment.count
 => 318
Request.count
 => 40564
 requests_with_item_comment.max_by { |req| req.created_at }.created_at
 => Fri, 04 Nov 2022 11:52:38.000000000 PDT -07:00

grouped = requests_with_item_comment.group_by(&:approval_status)
grouped.keys
 => ["approved", "marked_as_done"]
@cbeer
Copy link
Member

cbeer commented Jul 3, 2023

Ticket to come, but we'll be bringing back item comments for SAL-NEWARK material (post FOLIO? 🤞 ) so there's no sense removing or remediating it now.

@cbeer cbeer closed this as completed Jul 3, 2023
@saseestone
Copy link

saseestone commented Jul 4, 2023

Ticket describing SAL-NEWARK work: #1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants