Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle PagesController::UnpageableItemError with a 404 page or similar #1781

Open
cbeer opened this issue Aug 30, 2023 — with Honeybadger · 1 comment
Open

Gracefully handle PagesController::UnpageableItemError with a 404 page or similar #1781

cbeer opened this issue Aug 30, 2023 — with Honeybadger · 1 comment
Assignees
@hudajkhan
Labels
bug

Comments

@cbeer Honeybadger
Copy link
Member

cbeer commented Aug 30, 2023

Backtrace

line 12 of [PROJECT_ROOT]/app/controllers/pages_controller.rb: validate_request_type
line 22 of [PROJECT_ROOT]/app/controllers/requests_controller.rb: new

View full backtrace and more info at honeybadger.io
@hudajkhan hudajkhan self-assigned this Aug 30, 2023
@hudajkhan
Copy link
Contributor

sul-dlss/SearchWorks#3460 should address the underlying issue which is that the request button should not be available for this situation.

@cbeer cbeer changed the title [sul-requests/prod] PagesController::UnpageableItemError: PagesController::UnpageableItemError Gracefully handle PagesController::UnpageableItemError with a 404 page or similar Sep 19, 2023
@cbeer cbeer added the bug label Sep 19, 2023
@cbeer cbeer moved this from 📋 Backlog to 🔖 Ready in Searchworks/FOLIO Summer 2022/23 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hudajkhan hudajkhan

Labels
bug
Projects
Searchworks/FOLIO Summer 2022/23
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbeer @hudajkhan