Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text overflow display issues #1895

Open
cbeer opened this issue Oct 4, 2023 · 6 comments
Open

Fix text overflow display issues #1895

cbeer opened this issue Oct 4, 2023 · 6 comments

Comments

@cbeer
Copy link
Member

cbeer commented Oct 4, 2023

Screenshot 2023-10-04 at 11 10 58

https://searchworks.stanford.edu/view/L17771

@jcoyne
Copy link
Contributor

jcoyne commented Oct 4, 2023

@alundgard What should this look like when the item description is long and the description is long too (as seen in @cbeer's example)?

@alundgard
Copy link
Member

A quick fix may be to set height: fit-content; on the label element .form-control (or a similar solution that makes the row height fit the content). Also seems like an issue for mobile, where every row may be truncated:

mobile-row

@jcoyne
Copy link
Contributor

jcoyne commented Oct 4, 2023

@alundgard any concern that the thing that looks like a table header doesn't appear to encompass the width of this label?
Screenshot 2023-10-04 at 3 35 29 PM

@alundgard
Copy link
Member

It was also that way prior to bs4, right? It's not ideal but probably better than the alternatives: cramming the text content to fit into the Status "column"; or adjusting the container div width, which could get messy on mobile.

@alundgard
Copy link
Member

Something that could help a bit with that is setting text-align: right; on the span element .pull-right (or similar). So that the status message is right-justified with the Status "column":

mobile-row-align-right

@jcoyne
Copy link
Contributor

jcoyne commented Oct 4, 2023

@alundgard sul-requests is still on bs3. We haven't migrated it yet. I think this may be related to the switch to folio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants