Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update view to warn user if they have an existing request or loan #2495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update view to warn user if they have an existing request or loan #2495

wants to merge 1 commit into from

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Jun 13, 2024 •
edited
Loading

Screenshot 2024-06-14 at 12 18 42 PM
Screenshot 2024-06-14 at 12 10 39 PM
Screenshot 2024-06-14 at 12 09 54 PM

closes #2247

@dnoneill dnoneill force-pushed the user-warning-holds branch from 4ee8375 to 6fb6ce8 Compare June 13, 2024 19:44
@dnoneill dnoneill changed the title update view to warn user if they have an existing request update view to warn user if they have an existing request or loan Jun 13, 2024
@dnoneill dnoneill changed the title update view to warn user if they have an existing request or loan update view to warn user if they have an existing request Jun 13, 2024
@dnoneill dnoneill force-pushed the user-warning-holds branch 3 times, most recently from 2e3c891 to 3819fde Compare June 14, 2024 16:31
@dnoneill dnoneill changed the title update view to warn user if they have an existing request update view to warn user if they have an existing request or loan Jun 14, 2024
@dnoneill dnoneill force-pushed the user-warning-holds branch from 3819fde to c562f5d Compare June 14, 2024 16:42
@dnoneill
Copy link
Contributor Author

dnoneill commented Jun 14, 2024 •
edited
Loading

Note this also shows up on the scan view

Screenshot 2024-06-14 at 12 43 10 PM

@dnoneill dnoneill marked this pull request as ready for review June 14, 2024 16:56
@dbranchini
Copy link

Small issue, but any chance we can get the "On order" status on one line instead of wrapping? It should be call number and item status on one line and then the alert, if it exists, beneath it. Also, a question, for the multi-item radio buttons for scan requests, is the width of the alert in the multi-item select not as wide? It looks much smaller.

@dnoneill
Copy link
Contributor Author

Can do. No that was just my browser size was different when taking screenshots.

@dnoneill dnoneill force-pushed the user-warning-holds branch from c562f5d to e56078c Compare June 14, 2024 21:10
@dnoneill
Copy link
Contributor Author

@dbranchini Done. Was item note or bound-withs supposed to span the entire row (like this) as well or was it just this?
Screenshot 2024-06-14 at 17-09-54 Request African media barometer Benin

@dnoneill
Copy link
Contributor Author

@dbranchini ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the user a warning if they have an existing request for the title or it is checked out to them
2 participants
@dnoneill @dbranchini