Validate user input to prevent GraphQL injection attack #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Jul 9, 2024
| @@ -39,6 +39,9 @@ def current_request | |||
|
|
|||
| def assign_new_attributes | |||
| @patron_request.assign_attributes(**new_params) | |||
| # This validation prevents an injection attack in GraphQL. Ideally, this would be a model validation, | |||
| # but there are other validations that require first running a GraphQL query. | |||
| raise ActionController::BadRequest unless /\Aa?\d+\z/.match?(new_params[:instance_hrid]) | |||
There was a problem hiding this comment.
This regex is.. starts with an a or a digit? We also have hrids that start with L, or in, and probably arbitrary now in FOLIO.
There was a problem hiding this comment.
Yes. I've updated it include those cases as well.
cbeer
reviewed
Jul 9, 2024
| @@ -39,6 +39,9 @@ def current_request | |||
|
|
|||
| def assign_new_attributes | |||
| @patron_request.assign_attributes(**new_params) | |||
| # This validation prevents an injection attack in GraphQL. Ideally, this would be a model validation, | |||
| # but there are other validations that require first running a GraphQL query. | |||
| raise ActionController::BadRequest unless /\A(a|L|in)?\d+\z/.match?(new_params[:instance_hrid]) | |||
There was a problem hiding this comment.
I'm pretty -0 on this. I don't know that we'll be informed when new prefixes are used in FOLIO (and, like I said in my initial comment, I believe they can be arbitrary.)
There was a problem hiding this comment.
How about \w+? It seems bad for people to be injecting quotes, etc.
|
Obsoleted by #2524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2520