Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ORCID harvested publications work ok #1456

Open
peetucket opened this issue Mar 11, 2022 · 0 comments
Open

Ensure ORCID harvested publications work ok #1456

peetucket opened this issue Mar 11, 2022 · 0 comments
Labels

Comments

@peetucket
Copy link
Member

peetucket commented Mar 11, 2022

Before we enable ORCID harvesting, we should do two things:

  1. Verify the contribution records being created for both newly harvested publication and for existing publications (ie. in the database but need to be linked to a new author), both have valid publication_ids. See NoMethodError: undefined method `id' for nil:NilClass #1477 and prevent bad data from being created in contributions #1482

  2. Verify that citation generation works

There appears to be some custom mapping of names that used to create the formatted citations (APA, Chicago, MLA) that are added to the pub_hash, that is dependent on the data source (e.g. Pubmed vs WoS). We should ensure this works for ORCID sourced publications before turning on ORCID harvesting.

For example, see https://github.com/sul-dlss/sul_pub/blob/main/lib/csl/role_mapper.rb#L12-L31

This code uses the provenance to call different classes depending on the source. We need to sort out what happens for ORCID sourced publications, or else there may be issue generating a citation for these publications (unless the implicit fallback to this general method for mapping citation names works fine: https://github.com/sul-dlss/sul_pub/blob/main/lib/csl/role_mapper.rb#L54-L71)

@peetucket peetucket changed the title Ensure citation generation works for ORCID harvested publications Ensure ORCID harvested publications work ok Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant