Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Template Update #16

Open
alexander-schranz opened this issue Dec 1, 2022 · 4 comments
Open

XML Template Update #16

alexander-schranz opened this issue Dec 1, 2022 · 4 comments

Comments

@alexander-schranz
Copy link
Member

Add possibility to update xml templates. Via some rector processor.

-<controller>Sulu\Bundle\ArticleBundle\Controller\WebsiteArticleController:indexAction</controller>
+<controller>Sulu\Bundle\ArticleBundle\Controller\WebsiteArticleController::indexAction</controller>
@sabbelasichon
Copy link

@alexander-schranz I think that can be accomplished with a custom FileProcessor for xml files.
Have a look at: https://github.com/sabbelasichon/typo3-rector/blob/main/src/FileProcessor/FlexForms/FlexFormsProcessor.php

@alexander-schranz
Copy link
Member Author

@sabbelasichon thx for the response and your insights how you handle this in Typo3. Looks like this is just a file visitor then?
Do you know if there is there any AST based fileprocessor for yaml, xml already available?

@alexander-schranz
Copy link
Member Author

alexander-schranz commented Aug 17, 2023

If I understand rector 0.18 release correctly non PHP Files rectors are not longer supported now: https://getrector.com/blog/rector-018-refocus-on-php. @TomasVotruba deprecated them in rectorphp/rector-src#4761.

Not sure if there will be still a hook where we could upgrade other files or if we need for every file format binary doing the upgrade.

@sabbelasichon what are your plans here with the upgrade path for such files?

@sabbelasichon
Copy link

@alexander-schranz I am a bit late in responding. Sorry for that. We are currently developing a new tool to handle changes of non php files (https://github.com/andreaswolf/fractor). It is still under active development but we are expecting to have something ready end of June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants