Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black Background Does not work correctly #2

Closed
ido-ran opened this issue Jul 30, 2018 · 7 comments
Closed

Black Background Does not work correctly #2

ido-ran opened this issue Jul 30, 2018 · 7 comments

Comments

@ido-ran
Copy link

ido-ran commented Jul 30, 2018

I've try to use this add-on but when VS Code is in dark theme the keys are also written in black which makes it very hard to see.
The yellow key is visible when I hover the key with my mouse. The rest of the keys are black on black.

screen shot 2018-07-30 at 9 20 03

@lolpez
Copy link

lolpez commented Jul 30, 2018

Same here

image

@obambrough
Copy link

Switching 'Json Editor' to its dark theme ("vscode-json-editor.theme": "dark") helped (as opposed to changing my VS Code to a light theme.) But it would be nice if 'Json Editor' applied the existing VS Code theme to its underlying json editor.

@dlucazeau
Copy link

Hi
I have the same comments, and it would be nice if we can set color for elements of the tree view.
Thanks.

@sunmorgus
Copy link
Owner

Sorry for the lateness of it; however, version 0.2.1 should resolve this.

@FranklinYu
Copy link

@sunmorgus So in 0.2.1 the extension should detect theme automatically?

@sunmorgus
Copy link
Owner

Unfortunately, no... you'll still have to switch to the dark theme manually, but the background should hopefully blend better now.

@FranklinYu
Copy link

All right. I created #6 to track that. Will do more research about how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants