Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query block size from disk. #502

Open
todo bot opened this issue Oct 7, 2019 · 0 comments
Open

Query block size from disk. #502

todo bot opened this issue Oct 7, 2019 · 0 comments
Assignees
Labels
project-fs Related to fs todo 🗒️ Created by the todo bot type-feature New feature or request

Comments

@todo
Copy link

todo bot commented Oct 7, 2019

We shouldn't be hardcoding block sizes here. We should be querying them from the disk.


// TODO: Query block size from disk.
// BODY: We shouldn't be hardcoding block sizes here. We should be querying them
// BODY: from the disk.
/// Size of a block.
const BLOCK_SIZE: usize = 512;
/// Size of a block in u64.
const BLOCK_SIZE_U64: u64 = BLOCK_SIZE as u64;
impl<'a> PartitionManager<'a> {
/// Create a new partition manager.
pub fn new(inner: &'a mut dyn IStorage<Error = Error>) -> Self {


This issue was generated by todo based on a TODO comment in a2961e8 when #501 was merged. cc @roblabla.
@todo todo bot added the todo 🗒️ Created by the todo bot label Oct 7, 2019
@todo todo bot assigned roblabla Oct 7, 2019
@roblabla roblabla added project-fs Related to fs type-feature New feature or request labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-fs Related to fs todo 🗒️ Created by the todo bot type-feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant