Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: ensure to pin the version of every binary dependency #564

Open
roblabla opened this issue Mar 11, 2020 · 1 comment
Open

CI: ensure to pin the version of every binary dependency #564

roblabla opened this issue Mar 11, 2020 · 1 comment
Labels
infra Related to the infra/tooling. We're going meta.

Comments

@roblabla
Copy link
Member

roblabla commented Mar 11, 2020

Currently, binary dependencies are automatically installed by cargo-make. This is fine for personal builds, but it comes with two issues for CI:

  1. It will automatically install the newer version of binaries than the one specified
  2. It won't use the lockfile, leading to using newer version of the binarie's dependencies

Both can cause reproducibility to suffer. Currently, xargo and cargo-make are built with a specified version and lockfile separately, but it's not the case for mkisofs-rs or cargo-travis. Ideally, it'd be nice to have a flag we can use to tell cargo-make to enforce the installation of the version specified, and using the lockfile. I filed sagiegurari/cargo-make#381 on this topic.

@roblabla roblabla added infra Related to the infra/tooling. We're going meta. status-upstream Blocked by an upstream bug labels Mar 11, 2020
@roblabla roblabla removed the status-upstream Blocked by an upstream bug label Mar 23, 2020
@roblabla
Copy link
Member Author

Cargo-make now has an env variable to do this: CARGO_MAKE_CRATE_INSTALLATION_LOCKED=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Related to the infra/tooling. We're going meta.
Projects
None yet
Development

No branches or pull requests

1 participant