You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function uses recursion and taints its own cwd parameter. Later uses the filesystem cwd to create a relative path to return. This is incorrect since the point of passing in a cwd is for the function to work relative to that, not the filesystem cwd. Alternatively it could rely solely on the filesystem cwd (since the caller has a chance to modify it) and remove the cwd parameter
This bug only manifests when the cwd argument is not the same as the process cwd, such as when running in vscode extension.
I'm not sure what the callsites of this function are since CLI uses its own version of this function (rather, this function is probably based on the one in CLI).
The text was updated successfully, but these errors were encountered:
TheEdward162
changed the title
detectSuperJson incorrectly returns path to fs.cwd() instead of user provided cwd.
detectSuperJson incorrectly returns path relative to fs.cwd() instead of user provided cwd.
Dec 21, 2022
one-sdk-js/src/schema-tools/superjson/utils.ts
Line 52 in 2b51b09
The function uses recursion and taints its own
cwd
parameter. Later uses the filesystem cwd to create a relative path to return. This is incorrect since the point of passing in acwd
is for the function to work relative to that, not the filesystem cwd. Alternatively it could rely solely on the filesystem cwd (since the caller has a chance to modify it) and remove thecwd
parameterThis bug only manifests when the
cwd
argument is not the same as the process cwd, such as when running in vscode extension.I'm not sure what the callsites of this function are since CLI uses its own version of this function (rather, this function is probably based on the one in CLI).
The text was updated successfully, but these errors were encountered: