-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: make package/app choice explicit #222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWuzyk
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant rework of the template options with breaking changes because template parameters are renamed and options are removed.
Changes:
"project_type": ["package", "app"]
choice as the very first choice to make.package_(name|description|url)
toproject_(name|description|url)
.docker_image
a hidden parameter__docker_image
.with_jupyter_lab
.with_pydantic_typing
– enabled when selectingwith_fastapi_api
.with_sentry_logging
– handholding is of limited value for this feature.with_streamlit_app
– this is perhaps a little too opinionated as users may want to use Gradio instead.docstring_style
a hidden parameter__docstring_style
.async
endpoint instead a synchronous one, including a CPU-bound method (as that is a footgun with async FastAPI).rich
(typer.echo
is discouraged now).asyncio.to_thread
and pre-commit).Closes #219.