-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tn improve GitHub actions #8
Tn improve GitHub actions #8
Conversation
… compatible versions
…projects, and dev dependency only for other projects
… + fix docker base image conditional usage
…R_PUSH into DOCKER_BUILD_PUSH
…etry-cookiecutter into tn-improve-github-actions Get latest remote# the commit.
Hey @tanguyNaets, thanks for this PR! It's a pretty big one, so it will take some time to go through this in detail. Are there any smaller parts you could spin out into a separate PR so that we can get those improvements merged quicker already? |
In addition to the main goal of the PR (improve github actions), I could have the following PRs:
Apart for the 3rd one, is it really worth it for you having 1 and 2 in separate PRs? If so, I'll split them. LMK |
I removed the 3rd one since sentry is now a generic feature. RFR |
1 similar comment
I removed the 3rd one since sentry is now a generic feature. RFR |
Related: #63 |
Closing this PR as we've recently reworked the CI/CD pipelines in #206. |
(NOTE: test pipeline is currently failing because the previous PR to fix flake8-bandit is not part of
main
yet.)coverage
result as an artifact (previously, the purpose was apparently to send thecoverage
result to Codecov, but failed because Codecov requires a priced account and tokens to connect to it)Test
workflow before manual triggering ofDeploy
workflowfeature
,test
,development
,acceptance
,production
environments that get integrated with github web interface (similarly to what we achieve in gitlab ci)Deploy
workflow from running onacceptance
andproduction
environments if not tagged (similarly to what we achieve in gitlab ci)Publish
workflow from running ifTest
workflow failed in github actionsPublish
workflow poetry commands in the docker imageDOCKER_PUSH
variable into more understandableDOCKER_BUILD_PUSH
DOCKER_BUILD_PUSH
is set to 1 when deploying so App image building, tagging and pushing gets triggered.pyproject.toml
. For instance, it will try to major version a package, even if the package strategy in thepyproject.toml
is set to not bump, bump patch or bump minor