Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Phylotyper Integration #311

Open
kevinkle opened this issue Jun 20, 2018 · 0 comments
Open

Refactor Phylotyper Integration #311

kevinkle opened this issue Jun 20, 2018 · 0 comments

Comments

@kevinkle
Copy link
Member

@mwhitesi raised some good points about #309
We've currently hotfixed it for now, but here are Matt's points for a future refactor.

Does order matter? i.e. the phylotyper ontology graph is created before linking it to the results graph and its also created before checking if the loci exist. Not sure if building edges during the phylotyper ontology graph construction will add empty `:stx2a`, `:stx2b` nodes. I would check for the existence of the marker loci before creating the MarkerSequences object and going to the trouble of building the phylotyper ontology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant