Skip to content
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.

No application icon on GNU/Linux #53

Open
icarito opened this issue Sep 28, 2016 · 8 comments
Open

No application icon on GNU/Linux #53

icarito opened this issue Sep 28, 2016 · 8 comments

Comments

@icarito
Copy link

icarito commented Sep 28, 2016

Looks like superpowers.ico format isn't supported at least in XFCE4... running with Electron 1.4.1.

Thanks!

@elisee
Copy link
Contributor

elisee commented Sep 30, 2016

Hi! Thank for the report.

Anyone running XFCE4 able to try and fix this? Nobody on the core team runs it so we can't really test any fix easily.

@icarito
Copy link
Author

icarito commented Sep 30, 2016

I suppose it's a X11 standard so it should be the same on GNOME or KDE.
I've seen Marp markdown editor successfully does this, but my first attempt didn't work.

@minrwhite
Copy link

I can confirm that the icon does not display within GNOME 3.22.1. Manually changing the setupMainWindow() function to use a .png as the icon seems to work for me. @icarito, if I push a branch with these changes, would you like to test this for XFCE?

@icarito
Copy link
Author

icarito commented Nov 3, 2016

Sure!

On 03/11/16 09:36, Benjamin White wrote:

I can confirm that the icon does not display within GNOME 3.22.1.
Manually changing the |setupMainWindow()| function to use a |.png| as
the icon seems to work for me. @icarito https://github.com/icarito,
if I push a branch with these changes, would you like to test this for
XFCE?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#53 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMMS23OeXlL0aW2MXtMk1EuCgWZW24Pks5q6fFmgaJpZM4KIcMu.

@minrwhite
Copy link

See if this works

@icarito
Copy link
Author

icarito commented Nov 3, 2016

It does!

@icarito
Copy link
Author

icarito commented Nov 3, 2016

superappicon

@minrwhite
Copy link

Marvellous, will open this as a PR then.

minrwhite added a commit to minrwhite/superpowers-app that referenced this issue Nov 7, 2016
minrwhite added a commit to minrwhite/superpowers-app that referenced this issue Nov 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants