Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot have multiple navs on page #20

Open
KyleTryon opened this issue Dec 11, 2023 · 4 comments
Open

[Bug] Cannot have multiple navs on page #20

KyleTryon opened this issue Dec 11, 2023 · 4 comments

Comments

@KyleTryon
Copy link

It appears as though the navbar is not an "island", resulting in the menu buttons having a shared state. Having two navs in two separate components on the same page, will open and close in unison.

@surjithctly
Copy link
Owner

Currently the menu looks for an ID to close and open items and we do not have a parent wrapper since its headless. If we added a wrapper, it might break existing users, so only can do this on a major version. Until then, only one navigation is possible.

I'll keep this open.

@SalahAdDin
Copy link

Currently the menu looks for an ID to close and open items and we do not have a parent wrapper since its headless. If we added a wrapper, it might break existing users, so only can do this on a major version. Until then, only one navigation is possible.

I'll keep this open.

We could handle it by giving the id as property.

@surjithctly
Copy link
Owner

@SalahAdDin Are you able to open a PR?

@SalahAdDin
Copy link

@SalahAdDin Are you able to open a PR?

I will check it then,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants